Add Hyprstream#16
Conversation
Native OpenAction plugin for Hyprland — workspaces, window state, audio, capture, MPRIS with album art, and system displays. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This PR looks compliant, thanks. Before I merge this, I'd like to know what Mic Mute, Speaker Mute, Volume Step, Media Control, Clock, CPU, RAM, Battery, Temperature, and Uptime actions are doing in a Hyprland plugin. It seems like all of those actions are all already provided at least once by PipeWire Audio Control, Redline Monitor, Linux Media and System Information, if not already provided multiple times. This plugin already has quite a few Hyprland actions and adding those on top seems to just add clutter in my opinion, and is misleading when the plugin describes itself as a utility for Hyprland. I'd like to request that you remove those actions from this plugin, and if you have any specific need for functionality that they provide that the other plugins do not, either contribute that functionality to one of the existing plugins or create a separate plugin. |
|
Sure, sorry to have these overlapping features. |
|
@nekename I was wondering if I can split these actions you mentioned as separate new plugins like (hyprstream-media and hyprstream-monitors) so if anyone wants matching style buttons, they can use. |
|
I generally won't accept plugins that add features already provided by existing plugins, in order to keep the catalogue small and manageable. As I said, I'd be happy to merge a plugin that adds the ability to control the Hyprland compositor. Is there any reason you can't just customise the images of the action of the existing plugins? |
|
@danmaxis do you have plans to make the plugin have Hyprland actions only or should I close this PR? |
|
Sorry for hanging, it has been busy weeks. Could you leave it for just one more week? I will split the repo in the next days. |
|
Yes, of course. I understand being busy, no worries :) |
Reflects the split: audio, MPRIS media, and system-info actions moved to separate plugins. Matches the repo's updated About sidebar byte-for-byte. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Hi @nekename — thanks for your patience. Hyprstream is now Hyprland-compositor-only. I removed the actions you flagged as duplicates (mic/speaker mute, volume step, media control, clock, CPU, RAM, battery, temperature, uptime). What remains are 14 actions that control the compositor itself — workspaces, window focus/move/close/toggle/resize/swap, monitor-workspace swap, live config tweaks, presentation mode, screenshot/recording, do-not-disturb, and a diagnostics key. I've updated this PR's catalogue description to match, refreshed the repo's About sidebar, and cut a core-only release (v0.5.0) so the install pulls the trimmed plugin. The features I removed live on in separate plugins I may submit later, but this one is compositor-only per your guidance. Thanks for the review! |
|
Excellent work, thank you. I'm away for a few more days this month but I'd be happy to review and merge this when I get back. |
3 participants
Adds Hyprstream to section 2 (Native OpenAction plugins).
com.danmaxis.hyprstreamopenaction: added.Hyprstream/danmaxis).com.sfgrimes.pipewire-audio(CronusAK) andcom.havner.uinput(Havner) — alphabetical by repository URL within the section.icons/com.danmaxis.hyprstream.png.Hyprstream is a Linux-only plugin that turns a Stream Deck into a control surface for the Hyprland compositor. It ships 14 actions: workspace focus (numeric/named/special/scratchpad/relative), move window to workspace, directional window focus, close/toggle/resize/swap window, swap monitor workspaces, live config tweaks, presentation mode, screenshot, screen recording, do-not-disturb, and a connection diagnostics key.
The audio, MPRIS media, and system-info actions from the earlier revision have been removed and moved to separate plugins, per review feedback.